✨ Adds pypi_update_top_package_stats management command #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saadmk11
reviewed
May 24, 2024
package/management/commands/pypi_update_download_package_stats.py
Outdated
Show resolved
Hide resolved
package/management/commands/pypi_update_download_package_stats.py
Outdated
Show resolved
Hide resolved
package/management/commands/pypi_update_download_package_stats.py
Outdated
Show resolved
Hide resolved
package/management/commands/pypi_update_download_package_stats.py
Outdated
Show resolved
Hide resolved
…ts.py Co-authored-by: Maksudul Haque <saad.mk112@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Maksudul Haque <saad.mk112@gmail.com>
Co-authored-by: Maksudul Haque <saad.mk112@gmail.com>
…ts.py Co-authored-by: Maksudul Haque <saad.mk112@gmail.com>
Co-authored-by: Maksudul Haque <saad.mk112@gmail.com>
Agreed. That's why I added the other tool but it's kind of annoying if everything isn't automated. Definitely doable with a v2. |
|
Since this is new and doesn't change anything that's existing, I'm going to go with it. |
jefftriplett
added a commit
that referenced
this pull request
May 24, 2024
* ✨ Adds pypi_update_top_package_stats management command * 🔥 Removes unused variable * ✨ Adds other management command * 🤝 Update package/management/commands/pypi_update_download_package_stats.py Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * 🤝 Update package/management/commands/pypi_update_top_package_stats.py Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> * 🤝 Update package/management/commands/pypi_update_top_package_stats.py Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> * 🚜 Update package/management/commands/pypi_update_download_package_stats.py Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> * 📝 Apply suggestions from code review Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> * 🔥 Removes filename * 🚜 Applies PR feedback --------- Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
jefftriplett
added a commit
that referenced
this pull request
May 24, 2024
* 👕 Lints .env.local.example * ⚙️ Adds compose to ignore list * 🔥 Remove compose override example * 👕 Lints start-dev.sh * 🚜 Upgrades compose recipes * 🚜 Update docker-compose and python -m usage * 🚜 docker-compose => docker compose * ✨ Adds pypi_update_top_package_stats management command (#1160) * ✨ Adds pypi_update_top_package_stats management command * 🔥 Removes unused variable * ✨ Adds other management command * 🤝 Update package/management/commands/pypi_update_download_package_stats.py Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * 🤝 Update package/management/commands/pypi_update_top_package_stats.py Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> * 🤝 Update package/management/commands/pypi_update_top_package_stats.py Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> * 🚜 Update package/management/commands/pypi_update_download_package_stats.py Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> * 📝 Apply suggestions from code review Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> * 🔥 Removes filename * 🚜 Applies PR feedback --------- Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * 🔖 bump version 2024.5.6 -> 2024.5.7 * 🚜 docker-compose => docker compose --------- Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Automated Publisher <actions@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1065 and #834
This pulls data for the top 8000 Python packages, which hits about 4 to 5% of our packages, which isn't great.
pypi_update_download_package_stats.pyis a little clunky. It requires Seth's monthly pypi stats bundle. https://github.com/sethmlarson/pypi-dataI'm not sure if it's worth using the GitHub Release api to try and find it or if we should go another direction.