Game become unstable

[Lilobast]

Hello,
first of all, great work on this mod!

I noticed that the game slow down with time until the songs load indefinitely
before that, the game pull me some random lag spike more and more with time

there is some logs if it can be useful:
2023.03.27.14.22.55.log.gz

[DJDavid98]

Does this only happen with both BSDataPuller and bsrpc installed, or even if you only have BSDataPuller installed? I have had this issue myself but I have not been able to reliably reproduce it.

[Lilobast]

just tested that before posting the issue
only happens when bsrpc is installed

but I don't know if BSDataPuller is actively used when bsrpc is uninstalled🤔

[DJDavid98]

It should still be operating in the background, there are some overlays over on ReadieFur's website which utilize the data coming from it: https://readiefur.com/bsdp-overlay/browser/?q=%7B%22filter%22%3A%22none%22%2C%22searchData%22%3A%22%22%2C%22page%22%3A1%7D

My mod does not connect to the WebSocket that the browser-based overlays use but rather reads the data from the BSDataPuller mod directly, so there is a chance there's some kind of memory leak in the process. I have not been able to find the root cause of this issue thus far unfortunately, I've had these slowdowns since 1.26.0

[Lilobast]

yup, I don't remember having issues before 1.27.0
first time I noticed this was when playing with a friends in multiplayer
I had to restart my game a few times because I couldn't select a song x)

[DJDavid98]

If the issue is localized to my mod only and not coming from any of the dependencies I have a suspicion what might cause it, as I'm sending data to the RPC server on a timer in case the DapaPuller is sending no updates on its own, and I will fully admit my C# knowledge is not the best, so there is a chance that that timer may be causing this issue.

I'll see what I can do about this on my end, maybe test out removing it and see if that helps, but if the issue is not in my mod but in DiscordCore for example, I realistically don't have enough experience to fix that. I've tried packaging in newer versions of the Discord Game SDK similar to that mod as it's quite old, but had no success with that either.

[Lilobast]

just played without bsrp, went fine as far as I can see
good luck with the debugging :)

[DJDavid98]

I released v1.0.5 which removes said timer, and I was also able to upgrade to the latest Discord Game SDK by forking DiscordCore. Please give this version a try and see if it helps with the lag. If this doesn't fix it, I'm afraid there's not a whole lot I can do with my current Beat Saber modding knowledge.

[Lilobast]

I just tested with a ~1h gameplay,
seems good to me :)
No stutters or slow downs,
thanks for the great work!

[DJDavid98]

I'm happy to hear that, I'll close the issue in that case, feel free to reopen it if you encounter this problem again.