feat: similar authors #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows for regions with non-standard genre lengths fixes #571
avoid this by using redirectOverride options; also improve getName function; fix buildUrl params option
…ine redundant ApiBook types After some testing, it seems Audible is inconsistent with how books in a series are labeled. To combat this, we will now allow single and multi part books to contain a series/publication. We can also remove BookSchema, because chapterInfo doesn't seem to ever be attached to a book, so not sure why this was created. Also, since series are optional, we can put those into the main book type fixes #589
Coverage report
Show files with reduced coverage 🔻
Test suite run success283 tests passing in 25 suites. Report generated by 🧪jest coverage report action from d18f7ab |
also use live html page for testing, because trust issues
Merged
djdembeck
added a commit
that referenced
this pull request
Jun 22, 2023
* feat: similar authors (#567) * refactor(helper): ♻️ allow re-using asin10 regex by removing anchors * build: ➕ add `redoc-cli` as dev dep for generating html docs * docs: 📝 update api spec and html adds example responses; remove unused fields that aren't currently returned for author; fix rating showing number and releaseDate using date instead of date-time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/simsdoesn't seem to work anymore. Book similarity might need to be scraped, which isn't optimal.