You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All the context about what's broken and how to fix it are in this review thread: #257 (review)
But as mentioned in the last comment, performing this change has two big knock-on effects that need discussion
If the change is a hard one, people with invalid PCBIDs are going to start getting crashing games (albeit with a hopefully very easy to action log message)
Servers currently work around the broken dongle IDs, and this might trip them up
My initial thought I think seems fairly robust, if a little unclean: if the PCBID has a valid checksum (i.e. it's currently valid for our broken algo), then send it as per the old algorithm. Otherwise, if it has a valid newstyle header and invalid checksum (because bemanitools should be expected to calculate it), then process in the new way.
I think it's not too hard of a task to get server operators informed, so maybe a hard fix is the better long-term solution.
The text was updated successfully, but these errors were encountered:
All the context about what's broken and how to fix it are in this review thread: #257 (review)
But as mentioned in the last comment, performing this change has two big knock-on effects that need discussion
My initial thought I think seems fairly robust, if a little unclean: if the PCBID has a valid checksum (i.e. it's currently valid for our broken algo), then send it as per the old algorithm. Otherwise, if it has a valid newstyle header and invalid checksum (because bemanitools should be expected to calculate it), then process in the new way.
I think it's not too hard of a task to get server operators informed, so maybe a hard fix is the better long-term solution.
The text was updated successfully, but these errors were encountered: