Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with a migration plan to fix broken dongle IDs for certain roundplug games #260

Open
mon opened this issue Aug 14, 2023 · 0 comments

Comments

@mon
Copy link
Contributor

mon commented Aug 14, 2023

All the context about what's broken and how to fix it are in this review thread: #257 (review)

But as mentioned in the last comment, performing this change has two big knock-on effects that need discussion

  1. If the change is a hard one, people with invalid PCBIDs are going to start getting crashing games (albeit with a hopefully very easy to action log message)
  2. Servers currently work around the broken dongle IDs, and this might trip them up

My initial thought I think seems fairly robust, if a little unclean: if the PCBID has a valid checksum (i.e. it's currently valid for our broken algo), then send it as per the old algorithm. Otherwise, if it has a valid newstyle header and invalid checksum (because bemanitools should be expected to calculate it), then process in the new way.

I think it's not too hard of a task to get server operators informed, so maybe a hard fix is the better long-term solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant