Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '_Unsigned' flag processing to__getitem__() in abi_base.py. #1

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Conversation

yufeizhu600
Copy link

Since the auto masking and scaling is been set to 'False' when calling xr.open_dataset() function in init. The data were loaded as integer. This PR add casting the dtype of data and the fill_value from 'int' to 'uint' when the '_Unsigned' flag is True in the source netcdf file.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff
  • Fully documented

Copy link
Owner

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's tricky. Thanks.

@djhoese djhoese merged commit 3d6cfb7 into djhoese:feature-abi-l2-categories Sep 27, 2019
@yufeizhu600 yufeizhu600 deleted the patch-1 branch November 8, 2019 16:47
djhoese pushed a commit that referenced this pull request Jan 6, 2020
djhoese pushed a commit that referenced this pull request Mar 25, 2020
Add CLM/OCA grib products from the data centre
djhoese pushed a commit that referenced this pull request Aug 7, 2020
djhoese pushed a commit that referenced this pull request Sep 18, 2022
Rewrite CF reader tests to use pytest
djhoese pushed a commit that referenced this pull request Jan 25, 2023
Fixes for bugbear complaints
djhoese pushed a commit that referenced this pull request Feb 6, 2023
Merging the changes from PR#2207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants