Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer covering up bottom on page-body #55

Closed
rtgibbons opened this issue Jan 23, 2015 · 6 comments
Closed

footer covering up bottom on page-body #55

rtgibbons opened this issue Jan 23, 2015 · 6 comments

Comments

@rtgibbons
Copy link
Contributor

Looks like the page-body isn't being adjusted properly for the fixed footer.

This is noticeable when content reaches the bottom of the page. i.e. configuration and console output screens. Here is an example screenshot

avbch-be_wltuc8qqmqjpf1jfzktistydcxp19xhfxc

@rtgibbons
Copy link
Contributor Author

BTW, this is on Safari 8 and Chrome Canary 42

@rtgibbons
Copy link
Contributor Author

I think the issue might be height: 100%!important; being applied to #page-body (here) and possibly .row

When I remove this from #page-body the content flow fixed itself; but there is a horizontal scroll. Removing this from .row at the same time; remove the scroll but kept the scrollbar.

So, Adding overflow-x: hidden to #page-body remove the scroll bar.

I'm not sure the purpose of having the height set to 100%, or what issues will arise out of overflow-x: hidden

@barkingfoodog
Copy link

I adjusted the #page-body to height: 85%!:important; and that cleaned up the issue for me in Safari 8. Yes, that was a total hack and there's likely more elegant ways to fix this issue, but it worked well enough for my purposes. I don't see any problems with a horizontal scroll appearing.

@rtgibbons
Copy link
Contributor Author

Yeah; it fixes it - but it creates a weird gap when the page is real tall; or contains to cut it off when the page is too short.

I'm running off a branch right now with overflow-x: hidden and it's seems to work well. I submitted the pull request #58 for you to see the diff

@rtgibbons
Copy link
Contributor Author

This might be related to issue #57 , might what to see if the fix being pushed out by Jenkins in 1.597 fixes it

@rtgibbons
Copy link
Contributor Author

This too was fixed upstream in Jenkins 1.598 (actually there is another issue now with the footer causing too much spacing; not sure if upstream issue or theme :/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants