Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and Apply partial visible until reaching the bottom #57

Closed
rtgibbons opened this issue Jan 23, 2015 · 5 comments
Closed

Save and Apply partial visible until reaching the bottom #57

rtgibbons opened this issue Jan 23, 2015 · 5 comments

Comments

@rtgibbons
Copy link
Contributor

The Save and Apply buttons are only partially visible until we've scrolled all the way to the bottom.

screenshot 2015-01-23 10 07 25

I took a look at how the un-styled Jenkins works, and they are completely hidden until you've reach the bottom of the page; and then they are shown. The code for this seems to be in hudson-behavior.js around line 1157 (Using Safari Inspector).

But the comment states

/*
    Use on div tag to make it sticky visible on the bottom of the page.
    When page scrolls it remains in the bottom of the page
    Convenient on "OK" button and etc for a long form page
*/

So not sure if this behavior was changed on purpose, or if it's a bug in their code

This is on Jenkins 1.597.

@ctrl-f5
Copy link

ctrl-f5 commented Jan 23, 2015

this makes some pages unusable, also the console log is not visible to the bottom.

The wole page body is "position: fixed", there must be a better solution to this...

@rtgibbons
Copy link
Contributor Author

@ctrl-f5 Yeah - but this position: fixed is coming from Jenkins; so we are either stuck working with it or submitting a larger changes to Jenkins

@ctrl-f5
Copy link

ctrl-f5 commented Jan 23, 2015

aha, I see, I'll try to dig into it this weekend. Either way, it's always possible to override it, depending on how much jenkins relies on it.

@rtgibbons
Copy link
Contributor Author

This looks to be a bug in Jenkins - should be fixed on the next release (1.598)

https://issues.jenkins-ci.org/browse/JENKINS-26312

@rtgibbons
Copy link
Contributor Author

This was fixed upstream in 1.597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants