Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen readers read same content multiple times #55

Closed
jeryj opened this issue Jun 23, 2016 · 4 comments
Closed

Screen readers read same content multiple times #55

jeryj opened this issue Jun 23, 2016 · 4 comments

Comments

@jeryj
Copy link

jeryj commented Jun 23, 2016

Nice work on Bungee! It's a beautiful font and a very elegant implementation of a difficult task.

When a layered version of Bungee is generated, it repeats the same content several times to give the visual effect. For screen readers, this means the content gets read for each time the content appears. If the text is layered 4x to create the visual effect, it'll get read 4x by a screen reader.

To fix this, you can leave the first time the font is displayed as is, but for any additional ones generated, add aria-hidden="true" role="presentation" to the HTML so the screen reader knows to ignore it. Here's an example:

<figure class="bungee regular-ffffff background-2b859d inline-e8e8e7 shade-215966 sign-247082 horizontal regular inline shade background sign" id="preview" data-max-font-size="30vh" style="font-size: 145px;">
    <div>
        <div class="layer background" style="background-color: rgb(43, 133, 157);"></div>
        <div class="layer text regular" style="color: rgb(255, 255, 255);">
            <span>Tester</span>
        </div>
        <div class="layer text inline" style="color: rgb(232, 232, 231);" aria-hidden="true" role="presentation">
            <span>Tester</span>
        </div>
        <div class="layer text shade" style="color: rgb(33, 89, 102);" aria-hidden="true" role="presentation">
            <span>Tester</span>
        </div>
    </div>
</figure>

You can read more about why this works here: http://john.foliot.ca/aria-hidden/

Again, great work! Looking forward to using it sometime :)

@ghost ghost self-assigned this Jun 23, 2016
@davelab6
Copy link
Collaborator

davelab6 commented Jun 23, 2016 via email

@ghost
Copy link

ghost commented Jun 23, 2016

Great catch, thank you. 2294741

@ghost ghost closed this as completed Jun 23, 2016
@jeryj
Copy link
Author

jeryj commented Jun 23, 2016

Quick turnaround and clever fix! 💯 💯 💯

@djrrb
Copy link
Owner

djrrb commented Jun 23, 2016

Thanks @jeryj and @chrissam42!!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants