Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next launch date showing a past date #6

Closed
IanAdd opened this issue Sep 19, 2020 · 4 comments
Closed

next launch date showing a past date #6

IanAdd opened this issue Sep 19, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@IanAdd
Copy link

IanAdd commented Sep 19, 2020

Due the delaying of the Launch intended to be on Friday, the sensor is now showing me September 1 2020 10:00am. (AEST)
If the api returns a date in the past shouldn't you report N/A or similar ?

@mendhak
Copy link

mendhak commented Sep 19, 2020

For reference, I see the SpaceX API https://api.spacexdata.com/v3/launches/next is showing Sep 1 as the next launch date and today is Sep 19.

launch_date_utc: "2020-09-01T00:00:00.000Z"

It does make sense to do a check on the value being sent back, maybe return some null value. I don't know if @djtimca may prefer to do this check in here or their Python library.

@djtimca
Copy link
Owner

djtimca commented Sep 19, 2020

I could add an additional sensor for confirmed launch day for backwards compatibility and return unavailable when confirmed flag is false. That my be the cleanest solution. Will add this in the next release.

@djtimca djtimca self-assigned this Sep 19, 2020
@djtimca djtimca added the enhancement New feature or request label Sep 19, 2020
@3ative
Copy link

3ative commented Sep 19, 2020

@djtimca Sounds like the best way 👌
Great job on the integration BTW. Many Thanks. 👍

@djtimca
Copy link
Owner

djtimca commented Sep 21, 2020

Fixed in version 011 release. Also added device information and rewrote updates to better leverage the data coordinator from HA. Note will require version .115 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants