Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming: TypeSystem.create_type but add_feature #173

Closed
reckart opened this issue Aug 13, 2021 · 0 comments
Closed

Naming: TypeSystem.create_type but add_feature #173

reckart opened this issue Aug 13, 2021 · 0 comments
Assignees
@jcklie
Labels
🆕Enhancement Module: Type System
Milestone
0.6.0

Comments

@reckart
Copy link
Member

reckart commented Aug 13, 2021

The naming for creating how typesystem-related entities seems inconsistent. E.g. we have a create_type but then a add_feature method. For consistency, the latter should be renamed to create_feature.

Also, there should be a remark on the Type.add_feature() method that it should not be used (maybe even prefix it with _ and that the TypeSystem.create_feature() method should be used instead.

Best deprecate the old names instead of removing.
@jcklie jcklie self-assigned this Aug 14, 2021
@jcklie jcklie added this to the 0.6.0 milestone Aug 14, 2021
jcklie added a commit that referenced this issue Aug 14, 2021
@jcklie
#173 - Naming: TypeSystem.create_type but add_feature
d69bb6b 
- Add create_feature
- Deprecate add_feature
jcklie added a commit that referenced this issue Aug 14, 2021
@jcklie
#173 - Naming: TypeSystem.create_type but add_feature
5745faa 
- Update README
jcklie added a commit that referenced this issue Aug 14, 2021
@jcklie
#173 - Rename add_feature to create_feature (#177)
445fa3a 
- Add create_feature
- Deprecate add_feature
- Update README
@jcklie jcklie closed this as completed Aug 14, 2021
reckart added a commit that referenced this issue Aug 19, 2021
@reckart
Merge branch 'main' into feature/168-Experimental-JSON-CAS-support
13e9816 
* main:
  #172 - Naming: cas.add_annotation(s) (#181)
  #175 - Set a feature if the feature name is in a variable (#180)
  #175 - Set a feature if the feature name is in a variable
  #174 - FSes that are only transitively referenced cannot be serialized (#179)
  #170 - Handling of the "uima.noNamespace" prefix (#178)
  No issue
  #173 - Rename add_feature to create_feature (#177)

# Conflicts:
#	cassis/typesystem.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcklie jcklie

Labels
🆕Enhancement Module: Type System
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@jcklie @reckart