Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#173 - Rename add_feature to create_feature #177

Merged
merged 2 commits into from
Aug 14, 2021
Merged

#173 - Rename add_feature to create_feature #177

merged 2 commits into from
Aug 14, 2021

Conversation

jcklie
Copy link
Collaborator

@jcklie jcklie commented Aug 14, 2021

  • Add create_feature
  • Deprecate add_feature

@jcklie jcklie added this to the 0.6.0 milestone Aug 14, 2021
@jcklie jcklie self-assigned this Aug 14, 2021
@codecov
Copy link

codecov bot commented Aug 14, 2021 •
edited
Loading

Codecov Report

Merging #177 (5745faa) into master (9db7617) will decrease coverage by 0.04%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   97.53%   97.49%   -0.05%     
==========================================
  Files           9        9              
  Lines        1869     1873       +4     
==========================================
+ Hits         1823     1826       +3     
- Misses         46       47       +1
Impacted Files Coverage Δ
cassis/typesystem.py 96.51% <96.00%> (-0.19%) ⬇️
tests/test_typesystem.py 99.17% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db7617...5745faa. Read the comment docs.

@jcklie jcklie merged commit 445fa3a into master Aug 14, 2021
@jcklie jcklie deleted the feature/173-create-feature branch August 14, 2021 14:54
reckart added a commit that referenced this pull request Aug 19, 2021
@reckart
Merge branch 'main' into feature/168-Experimental-JSON-CAS-support
13e9816 
* main:
  #172 - Naming: cas.add_annotation(s) (#181)
  #175 - Set a feature if the feature name is in a variable (#180)
  #175 - Set a feature if the feature name is in a variable
  #174 - FSes that are only transitively referenced cannot be serialized (#179)
  #170 - Handling of the "uima.noNamespace" prefix (#178)
  No issue
  #173 - Rename add_feature to create_feature (#177)

# Conflicts:
#	cassis/typesystem.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jcklie jcklie

Labels
🆕Enhancement Module: Type System
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jcklie