Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming: cas.add_annotation(s) #172

Closed
reckart opened this issue Aug 13, 2021 · 1 comment · Fixed by #181
Closed

Naming: cas.add_annotation(s) #172

reckart opened this issue Aug 13, 2021 · 1 comment · Fixed by #181
Assignees
@jcklie
Labels
⚙️Refactoring
Milestone
0.6.0

Comments

@reckart
Copy link
Member

reckart commented Aug 13, 2021

Since the add_annotation(s) methods can also add things which as not inheriting from uima.cas.Annotation, the naming of the method seems a bit misleading.

Maybe stick with the add_to_indexes() or simply add()?

Same for remove_annotation(s)
@jcklie jcklie self-assigned this Aug 13, 2021
@jcklie jcklie added this to the 0.6.0 milestone Aug 13, 2021
@jcklie
Copy link
Collaborator

jcklie commented Aug 13, 2021

I would do that but deprecate the old way also and delete it later

jcklie added a commit that referenced this issue Aug 14, 2021
@jcklie
#172 - Naming: cas.add_annotation(s)
413a32d 
- cas.add_annotations -> cas.add
jcklie added a commit that referenced this issue Aug 14, 2021
@jcklie
#172 - Naming: cas.add_annotation(s)
32fc09e 
- cas.add_annotations -> cas.add_all
jcklie added a commit that referenced this issue Aug 14, 2021
@jcklie
#172 - Naming: cas.add_annotation(s)
13b11c7 
- cas.remove_annotation -> cas.remove
jcklie added a commit that referenced this issue Aug 14, 2021
@jcklie
#172 - Naming: cas.add_annotation(s) (#181)
9cdbd73 
- cas.add_annotation -> cas.add
- cas.add_annotations -> cas.add_all
- cas.remove_annotation -> cas.remove
@jcklie jcklie linked a pull request Aug 14, 2021 that will close this issue
#172 - Naming: cas.add_annotation(s) #181
Merged
@jcklie jcklie closed this as completed Aug 14, 2021
reckart added a commit that referenced this issue Aug 19, 2021
@reckart
Merge branch 'main' into feature/168-Experimental-JSON-CAS-support
13e9816 
* main:
  #172 - Naming: cas.add_annotation(s) (#181)
  #175 - Set a feature if the feature name is in a variable (#180)
  #175 - Set a feature if the feature name is in a variable
  #174 - FSes that are only transitively referenced cannot be serialized (#179)
  #170 - Handling of the "uima.noNamespace" prefix (#178)
  No issue
  #173 - Rename add_feature to create_feature (#177)

# Conflicts:
#	cassis/typesystem.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcklie jcklie

Labels
⚙️Refactoring
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

#172 - Naming: cas.add_annotation(s) dkpro/dkpro-cassis
2 participants
@jcklie @reckart