Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connl2012 writer uses WordSense, but does not declare it #1337

Closed
jcklie opened this issue Mar 13, 2019 · 0 comments
Closed

Connl2012 writer uses WordSense, but does not declare it #1337

jcklie opened this issue Mar 13, 2019 · 0 comments
Assignees
Labels
🐛Bug Something isn't working Module-io.conll
Milestone

Comments

@jcklie
Copy link
Contributor

jcklie commented Mar 13, 2019

See

    private void convert(JCas aJCas, PrintWriter aOut)
    {
        Map<Token, Collection<SemPred>> predIdx = indexCovered(aJCas, Token.class, SemPred.class);
        Map<SemArg, Collection<Token>> argIdx = indexCovered(aJCas, SemArg.class, Token.class);
        Map<Token, Collection<NamedEntity>> neIdx = indexCovering(aJCas, Token.class,
                NamedEntity.class);
        Map<Token, Collection<WordSense>> wordSenseIdx = indexCovered(aJCas, Token.class,
                WordSense.class);
        Map<Token, Collection<CoreferenceLink>> corefIdx = indexCovering(aJCas, Token.class,
                CoreferenceLink.class);
        Map<CoreferenceLink, Integer> corefChainIdx = new HashMap<>();
        ...
    }
@reckart reckart added this to the 1.11.0 milestone Mar 13, 2019
@reckart reckart added 🐛Bug Something isn't working Module-io.conll labels Mar 13, 2019
@reckart reckart self-assigned this Mar 13, 2019
reckart added a commit that referenced this issue May 6, 2019
- Added capabilities for CoreferenceHain, NamedEntity, and WordSense to CoNLL 2012 reader and writer
reckart added a commit that referenced this issue May 6, 2019
…-WordSense-but-does-not-declare-it

#1337 - Connl2012 writer uses WordSense, but does not declare it
@reckart reckart closed this as completed May 6, 2019
reckart added a commit that referenced this issue May 7, 2019
* master: (653 commits)
  #1299 - Update to CoreNLP 3.9.2
  #1337 - Connl2012 writer uses WordSense, but does not declare it
  #1299 - Update to CoreNLP 3.9.2
  No issue. Fixed JavaDoc error.
  #1340 - Upgrade dependencies (1.11.0)
  #1358 - Improve error messages in TSV3
  #1357 - Upgrade to ICU4J 64.2
  #1340 - Upgrade dependencies (1.11.0)
  #1343 - Segmenter for Chinese
  No issue. Formatting and remove dewac test since dewac model is no longer available.
  #186 - Change artifactId to "dkpro-core-XXX"
  #186 - Change artifactId to "dkpro-core-XXX"
  #186 - Change artifactId to "dkpro-core-XXX"
  #186 - Change artifactId to "dkpro-core-XXX"
  #186 - Change artifactId to "dkpro-core-XXX"
  #186 - Change artifactId to "dkpro-core-XXX"
  #186 - Change artifactId to "dkpro-core-XXX"
  #186 - Change artifactId to "dkpro-core-XXX"
  #186 - Change artifactId to "dkpro-core-XXX"
  #186 - Change artifactId to "dkpro-core-XXX"
  ...

% Conflicts:
%	dkpro-core-sfst-gpl/src/main/java/de/tudarmstadt/ukp/dkpro/core/sfst/SfstAnnotator.java
reckart added a commit that referenced this issue May 31, 2019
* master:
  #186 - Change artifactId to "dkpro-core-XXX"
  #1299 - Update to CoreNLP 3.9.2
  #1337 - Connl2012 writer uses WordSense, but does not declare it
  #1299 - Update to CoreNLP 3.9.2
  No issue. Fixed JavaDoc error.
  #1340 - Upgrade dependencies (1.11.0)
  #1358 - Improve error messages in TSV3
  #1357 - Upgrade to ICU4J 64.2
  #1340 - Upgrade dependencies (1.11.0)
  #1343 - Segmenter for Chinese
  #1343 - Segmenter for Chinese
  #1343 - Segmenter for Chinese
  #1343 - Segmenter for Chinese
  #1343 - Segmenter for Chinese
  #1340 - Upgrade dependencies

% Conflicts:
%	dkpro-core-decompounding-asl/src/test/java/org/dkpro/core/decompounding/uima/annotator/CompoundAnnotatorTest.java
%	dkpro-core-io-lxf-asl/src/main/java/org/dkpro/core/io/lxf/internal/DKPro2Lxf.java
reckart added a commit that referenced this issue Jun 4, 2019
* master:
  #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator
  #1362 - NifWriter does not write out NE identifier
  #1362 - NifWriter does not write out NE identifier
  #1152 - Introduce "order" feature on tokens
  #1366 - Added support in CONLL-U reader for document and paragraph IDs
  #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator
  #1366 - Added support in CONLL-U reader for document and paragraph IDs
  #1367 - Support TCF orthography via SofaChangeAnnotations
  #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator
  #1327 - Update LIF support
  #1366 - Added support in CONLL-U reader for document and paragraph IDs
  #1367 - Support TCF orthography via SofaChangeAnnotations
  Forgot to commit the list declaration
  Warn if CONLL-U file contains multiple documents
  Added support in CONLL-U reader for document and paragraph IDs
  #186 - Change artifactId to "dkpro-core-XXX"
  #1299 - Update to CoreNLP 3.9.2
  #1337 - Connl2012 writer uses WordSense, but does not declare it
  #1299 - Update to CoreNLP 3.9.2
  Added parameter to enable lower-cased lookup of first word in sentence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module-io.conll
Projects
None yet
Development

No branches or pull requests

2 participants