Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, that looks very useful. I see the default value of the parameter is "false". Should it maybe be "true"? Did you notice our contribution guidelines? It would be great if you could provide us with a CLA so we can merge the PR. |
* master: (653 commits) #1299 - Update to CoreNLP 3.9.2 #1337 - Connl2012 writer uses WordSense, but does not declare it #1299 - Update to CoreNLP 3.9.2 No issue. Fixed JavaDoc error. #1340 - Upgrade dependencies (1.11.0) #1358 - Improve error messages in TSV3 #1357 - Upgrade to ICU4J 64.2 #1340 - Upgrade dependencies (1.11.0) #1343 - Segmenter for Chinese No issue. Formatting and remove dewac test since dewac model is no longer available. #186 - Change artifactId to "dkpro-core-XXX" #186 - Change artifactId to "dkpro-core-XXX" #186 - Change artifactId to "dkpro-core-XXX" #186 - Change artifactId to "dkpro-core-XXX" #186 - Change artifactId to "dkpro-core-XXX" #186 - Change artifactId to "dkpro-core-XXX" #186 - Change artifactId to "dkpro-core-XXX" #186 - Change artifactId to "dkpro-core-XXX" #186 - Change artifactId to "dkpro-core-XXX" #186 - Change artifactId to "dkpro-core-XXX" ... % Conflicts: % dkpro-core-sfst-gpl/src/main/java/de/tudarmstadt/ukp/dkpro/core/sfst/SfstAnnotator.java
|
@ramonziai @rziai Since this is a commit to a GPL module, we cannot simply accept the PR under the contribution section of the Apache License - would you be able to provide a CLA? |
|
Can one of the admins verify this patch? |
Yes, I just sent a signed ICLA to licenses@ukp.informatik.tu-darmstadt.de. Will that be sufficient? |
|
Jenkins, can you test this please? |
* master: #186 - Change artifactId to "dkpro-core-XXX"
|
@ramonziai yep, thanks :) |
reckart
changed the title
…entence in SfstAnnotator - Formatting - Adjusting to changes in DKPro Core package names
|
Jenkins, can you test this please? |
…entence in SfstAnnotator - Add missing JavaDoc
|
Jenkins, can you test this please? |
- Commented out logging test because it fails on Jenkins/Windows
|
Jenkins, can you test this please? |
|
Jenkins, can you test this please? |
…entence in SfstAnnotator - Move changes to the right source file
|
Jenkins, can you test this please? |
|
|
reckart
added a commit
that referenced
this pull request
Jun 4, 2019
… of github.com:dkpro/dkpro-core into bugfix/1362-NifWriter-does-not-write-out-NE-identifier * 'bugfix/1362-NifWriter-does-not-write-out-NE-identifier' of github.com:dkpro/dkpro-core: #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator #1366 - Added support in CONLL-U reader for document and paragraph IDs #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator Added parameter to enable lower-cased lookup of first word in sentence.
reckart
added a commit
that referenced
this pull request
Jun 4, 2019
* master: #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator #1362 - NifWriter does not write out NE identifier #1362 - NifWriter does not write out NE identifier #1152 - Introduce "order" feature on tokens #1366 - Added support in CONLL-U reader for document and paragraph IDs #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator Added parameter to enable lower-cased lookup of first word in sentence. % Conflicts: % dkpro-core-io-conll-asl/src/test/java/org/dkpro/core/io/conll/ConllUReaderTest.java % dkpro-core-io-json-asl/src/test/resources/conll/2000/chunk2000_ref.json % dkpro-core-io-xmi-asl/src/test/resources/xmi/english.xmi
reckart
added a commit
that referenced
this pull request
Jun 4, 2019
* master: #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator #1362 - NifWriter does not write out NE identifier #1362 - NifWriter does not write out NE identifier #1152 - Introduce "order" feature on tokens #1366 - Added support in CONLL-U reader for document and paragraph IDs #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator #1366 - Added support in CONLL-U reader for document and paragraph IDs #1367 - Support TCF orthography via SofaChangeAnnotations #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator #1327 - Update LIF support #1366 - Added support in CONLL-U reader for document and paragraph IDs #1367 - Support TCF orthography via SofaChangeAnnotations Forgot to commit the list declaration Warn if CONLL-U file contains multiple documents Added support in CONLL-U reader for document and paragraph IDs #186 - Change artifactId to "dkpro-core-XXX" #1299 - Update to CoreNLP 3.9.2 #1337 - Connl2012 writer uses WordSense, but does not declare it #1299 - Update to CoreNLP 3.9.2 Added parameter to enable lower-cased lookup of first word in sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many full-form lexicons underlying morphological models do not handle uppercase versions of words. The result is that uppercase forms are not found and cannot be analyzed. This fix adds a parameter which enables the lookup of lowercase versions of sentence-initial words, depending on the locale of the document language.