Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NifWriter does not write out NE identifier #1362

Closed
jcklie opened this issue May 6, 2019 · 0 comments
Closed

NifWriter does not write out NE identifier #1362

jcklie opened this issue May 6, 2019 · 0 comments
Assignees
Labels
🐛Bug Something isn't working Module-io.nif
Milestone

Comments

@jcklie
Copy link
Contributor

jcklie commented May 6, 2019

When reading a nif file that contains named entities that are linked to a knowledge base, e.g. https://github.com/munnellg/1641DepositionsCorpus , and writing it out with the NifWriter, it looses these identifiers. Looking into DKPro2Nif,

String neIdentifier = uimaNamedEntity.getValue();

maybe should be

String neIdentifier = uimaNamedEntity.getidentifier();

and

if (neIdentifierIsUri) {
    nifNamedEntity.addProperty(pTaClassRef, m.createResource(neIdentifier));
}

maybe should be

if (neIdentifierIsUri) {
    nifNamedEntity.addProperty(pTaIdentRef, m.createResource(neIdentifier));
}
@reckart reckart added Module-io.nif 🐛Bug Something isn't working labels Jun 3, 2019
@reckart reckart self-assigned this Jun 3, 2019
@reckart reckart added this to the 1.11.0 milestone Jun 3, 2019
reckart added a commit that referenced this issue Jun 3, 2019
- Fix handling of NE identifier
- Added unit test
reckart added a commit that referenced this issue Jun 4, 2019
reckart added a commit that referenced this issue Jun 4, 2019
…ite-out-NE-identifier

#1362 - NifWriter does not write out NE identifier
@reckart reckart closed this as completed Jun 4, 2019
reckart added a commit that referenced this issue Jun 4, 2019
* master:
  #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator
  #1362 - NifWriter does not write out NE identifier
  #1362 - NifWriter does not write out NE identifier
  #1152 - Introduce "order" feature on tokens
  #1366 - Added support in CONLL-U reader for document and paragraph IDs
  #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator
  #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator
  Added parameter to enable lower-cased lookup of first word in sentence.

% Conflicts:
%	dkpro-core-io-conll-asl/src/test/java/org/dkpro/core/io/conll/ConllUReaderTest.java
%	dkpro-core-io-json-asl/src/test/resources/conll/2000/chunk2000_ref.json
%	dkpro-core-io-xmi-asl/src/test/resources/xmi/english.xmi
reckart added a commit that referenced this issue Jun 4, 2019
* master:
  #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator
  #1362 - NifWriter does not write out NE identifier
  #1362 - NifWriter does not write out NE identifier
  #1152 - Introduce "order" feature on tokens
  #1366 - Added support in CONLL-U reader for document and paragraph IDs
  #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator
  #1366 - Added support in CONLL-U reader for document and paragraph IDs
  #1367 - Support TCF orthography via SofaChangeAnnotations
  #1041 - Add parameter to enable lower-cased lookup of first word in sentence in SfstAnnotator
  #1327 - Update LIF support
  #1366 - Added support in CONLL-U reader for document and paragraph IDs
  #1367 - Support TCF orthography via SofaChangeAnnotations
  Forgot to commit the list declaration
  Warn if CONLL-U file contains multiple documents
  Added support in CONLL-U reader for document and paragraph IDs
  #186 - Change artifactId to "dkpro-core-XXX"
  #1299 - Update to CoreNLP 3.9.2
  #1337 - Connl2012 writer uses WordSense, but does not declare it
  #1299 - Update to CoreNLP 3.9.2
  Added parameter to enable lower-cased lookup of first word in sentence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module-io.nif
Projects
None yet
Development

No branches or pull requests

2 participants