Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a warning about old open PRs targeting stable #118

Open
wilzbach opened this issue Jul 1, 2017 · 2 comments
Open

Send a warning about old open PRs targeting stable #118

wilzbach opened this issue Jul 1, 2017 · 2 comments

Comments

@wilzbach
Copy link
Member

wilzbach commented Jul 1, 2017

http://forum.dlang.org/post/a66c8b4b-9ca4-de57-3b26-bf70498cdfca@puremagic.com

  • Maybe two days instead of one?
  • Mail to Dlang-internal?
@MartinNowak
Copy link
Member

To whom? I'm checking stable PR during betas, using a tinsy bash script.
https://github.com/MartinNowak/github_scripts/blob/62c7b0197f69d482e5dfbca55a950976fc681f09/list_branch_pulls.sh
Seems easier to do as part of the release script that to automate atm.

@wilzbach
Copy link
Member Author

I check them at auto-tester: https://auto-tester.puremagic.com/pulls.ghtml?projectid=14

BTW the bot already recognizes stalled PRs targetting stable (see e.g. dlang/phobos#5981), so it would be just a matter of instead of labelling, commenting with sth. like:

Hey everyone, this PR is targeting stable and hasn't received any activity in the last three days. PRs to stable should be simple bug fixes or receive a higher priority. @: If you need help to finish this PR, join # on Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants