Merge pull request #6541 from MartinNowak/fix17130

fix Issue 17130 - ambiguous implicit super call
dlang · Feb 15, 2017 · 69182da · 69182da
2 parents 8f23808 + cfeb41a
commit 69182da
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/src/dclass.d b/src/dclass.d
@@ -922,12 +922,15 @@ extern (C++) class ClassDeclaration : AggregateDeclaration
         //    this() { }
         if (!ctor && baseClass && baseClass.ctor)
         {
-            auto fd = resolveFuncCall(loc, sc2, baseClass.ctor, null, null, null, 1);
+            auto fd = resolveFuncCall(loc, sc2, baseClass.ctor, null, type, null, 1);
+            if (!fd) // try shared base ctor instead
+                fd = resolveFuncCall(loc, sc2, baseClass.ctor, null, type.sharedOf, null, 1);
             if (fd && !fd.errors)
             {
                 //printf("Creating default this(){} for class %s\n", toChars());
                 auto btf = cast(TypeFunction)fd.type;
                 auto tf = new TypeFunction(null, null, 0, LINKd, fd.storage_class);
+                tf.mod       = btf.mod;
                 tf.purity    = btf.purity;
                 tf.isnothrow = btf.isnothrow;
                 tf.isnogc    = btf.isnogc;

diff --git a/test/compilable/test17130.d b/test/compilable/test17130.d
@@ -7,10 +7,32 @@ class Base
     {}
 }
 
-class Derived : Base
+class Derived1 : Base
 {
     this()
     {
         // implicit super();
     }
 }
+
+class Derived2 : Base
+{
+    // implicit this()
+}
+
+class Base2
+{
+    this() shared
+    {}
+}
+
+class Derived3 : Base2
+{
+    // implicit this() shared
+}
+
+void test()
+{
+    auto d2 = new Derived2;
+    auto d3 = new shared(Derived3);
+}