fix Issue 17130 - ambiguous implicit super call #6541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MartinNowak
commented
Feb 14, 2017
MartinNowak
commented
- need to pass class type to resolveFuncCall
- also make implicit ctor shared for shared base ctor
- need to pass class type to resolveFuncCall - also make implicit ctor shared for shared base ctor
|
MartinNowak
commented
Feb 14, 2017
| auto fd = resolveFuncCall(loc, sc2, baseClass.ctor, null, null, null, 1); | ||
| auto fd = resolveFuncCall(loc, sc2, baseClass.ctor, null, type, null, 1); | ||
| if (!fd) // try shared base ctor instead | ||
| fd = resolveFuncCall(loc, sc2, baseClass.ctor, null, type.sharedOf, null, 1); |
There was a problem hiding this comment.
Handling shared base ctor was added to not break existing code, even though it never worked to actually instantiate a class like Derived3 (b/c of the unshared implicit ctor).
Implicitly declaring overloaded ctors is out of scope for the bugfix and is a topic for Issue 9066 – Add constructor inheritance feature.
|
@MartinNowak feel free to merge this yourself after it passes the unittests |
UplinkCoder
approved these changes
Feb 14, 2017
|
Thanks bringing this to completion, Martin! Last Sunday I debugged the code myself, but only got to |
tramker
pushed a commit
to tramker/dmd
that referenced
this pull request
Feb 8, 2018
fix Issue 17130 - [REG2.074] ambiguous implicit super call cherry-picked-by: Martin Krejcirik <mk@krej.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.