Fix Issue 11038 - static has no effect as a block attribute for imports

[RazvanN7]

The main function of the compiler (mars.d) calls importAll on the module before doing any semantic analysis. Since for blocks such as static{}, the storage class is updated during semantic analysis, the imports inside static blocks are brought in the module scope which results in the present bug.

The fix is to update the isstatic field of imports when it is first used.

I know that this requires a deprecation cycle, but I suspect that this is not a prevalent pattern and maybe we can get away directly with an error. Let's see what the tests say.

Later edit; it seems that phobos has this pattern:

package template MemberFunctionGenerator(alias Policy)
{
private static:
    import std.format;
    /* use of format without fully qualified name in some function */
}

It seems we have to go through a deprecation cycle.

[dlang-bot]

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	11038	enhancement	static has no effect as a block attribute for imports

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10541"

[RazvanN7]

I think that this case requires way too much engineering to trigger a deprecation. Currently, dmd has a pass that loads the scope of top-level non-static imports and then the symbols are considered in the scope of the module. So, for a deprecation to be emitted, you would need to test every symbol that is searched if it came from a static import; this might add overhead to highly used path of the code, raising compilation times. I suggest we just fix phobos and ship this as is.

[RazvanN7]

Ping. I think this one is ready to merge.

[thewilsonator]

Auto-merge toggled on

[RazvanN7]

Again, I can't see the label :-?