New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 20431 - Allow a Mixin Type to resolve to an expression #10629
Conversation
Thanks for your pull request and interest in making D better, @BorisCarvajal! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#10629" |
e591098
to
4f569ef
Compare
Please follow the correct form for subjects that fix bugzilla issues:
There's also no explanation of what the worse fix was? A link to it is needed.
Please do not mix multiple issues into one PR. |
4f569ef
to
ece7f2c
Compare
I've filed a new issue with a clear description now. |
This introduced a regression: https://issues.dlang.org/show_bug.cgi?id=21074 |
@MoonlightSentinel, thanks for reporting it. Fix #11458 |
This PR introduced another regression: https://issues.dlang.org/show_bug.cgi?id=22969 |
It also fix the parsing of mixin(basic type) in __traits(compiles) and using a mixin as an index in array declarations. See the test case.
A side effect is that the next code works now:
alias fun = mixin("(){}");