Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 20431 - Allow a Mixin Type to resolve to an expression #10629

Merged
merged 1 commit into from Dec 9, 2019

Conversation

BorisCarvajal
Copy link
Member

@BorisCarvajal BorisCarvajal commented Nov 28, 2019

It also fix the parsing of mixin(basic type) in __traits(compiles) and using a mixin as an index in array declarations. See the test case.

A side effect is that the next code works now:

alias fun = mixin("(){}");

@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 28, 2019

Thanks for your pull request and interest in making D better, @BorisCarvajal! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20431 minor Allow a Mixin Type to resolve to an expression where it makes sense

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10629"

@WalterBright
Copy link
Member

Your PR doesn't reference any Bugzilla issue.

Please follow the correct form for subjects that fix bugzilla issues:

fix Issue NNNN title

There's also no explanation of what the worse fix was? A link to it is needed.

It also fix the parsing of mixin(basic type) in __traits(compiles) and using a mixin as an index in array declarations.

Please do not mix multiple issues into one PR.

@BorisCarvajal
Copy link
Member Author

I've filed a new issue with a clear description now.

@BorisCarvajal BorisCarvajal changed the title Better fix for issue 20388 Fix issue 20431 - Allow a Mixin Type to resolve to an expression Dec 5, 2019
@dlang-bot dlang-bot merged commit 14f20c1 into dlang:stable Dec 9, 2019
@MoonlightSentinel
Copy link
Contributor

This introduced a regression: https://issues.dlang.org/show_bug.cgi?id=21074

@BorisCarvajal
Copy link
Member Author

@MoonlightSentinel, thanks for reporting it.

Fix #11458

@MoonlightSentinel
Copy link
Contributor

This PR introduced another regression: https://issues.dlang.org/show_bug.cgi?id=22969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants