Fix Issue 22969 - Can't mixin name of manifest constant on right-hand side of alias declaration #13946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…side of alias declaration Remove an unnecessary `typeToExpression` conversion call that forced `mixin` to be resolved via expression semantic (expanding enum constants when it shouldn't). This was a change I wanted to make some time ago but an early error somewhere in the type semantic prevented me (fixed here). Also a duplicated code in `traits.d` to handle mixins is removed (it was a copy of `typesem.d:compileTypeMixin` function).
|
Thanks for your pull request, @BorisCarvajal! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#13946" |
thewilsonator
approved these changes
Apr 4, 2022
RazvanN7
approved these changes
Apr 5, 2022
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove an unnecessary
typeToExpressionconversion call that forcedmixintobe resolved via expression semantic (expanding enum constants when it shouldn't).
This was a change I wanted to make some time ago but an early error somewhere
in the type semantic prevented me (fixed here).
Also a duplicated code in
traits.dto handle mixins is removed (it was a copyof
typesem.d:compileTypeMixinfunction).Regression caused by #10629