Fix issue 20638: only offer correction for module property if symbol is visible.

[FeepingCreature]

Similar to #10867 , but easier to check.

[dlang-bot]

Thanks for your pull request and interest in making D better, @FeepingCreature! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	20638	trivial	spelling correction offers private member of package on named package access

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#10868"

[FeepingCreature]

Note: The best solution would probably involve passing the scope down search_correct so that can exclude private symbols to start with. I'll take a look at that, see if it's easily done.

[FeepingCreature]

Nevermind, I misthought. When there's a direct match, you're right @thewilsonator that it's always correct to error with "tried to access private member" instead, so the question never comes up.

In the case class Class { private void foo(); public void fob(); }, obj.foo should always print a "private member not accessible" error, not go searching for misspellings, so the fact that the misspelling doesn't point it at fob is not an issue.

Fixing your bug would obviate the need for this PR, because it would run into the proper "private member not accessible" message instead, but until that's fixed this should be fine.