Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 20638: only offer correction for module property if symbol is visible. #10868

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Fix issue 20638: only offer correction for module property if symbol is visible. #10868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dmd/expressionsem.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11677,7 +11677,7 @@ Expression semanticY(DotIdExp exp, Scope* sc, int flag)
if (flag)
return null;
s = ie.sds.search_correct(exp.ident);
if (s)
if (s && symbolIsVisible(sc, s))
{
if (s.isPackage())
exp.error("undefined identifier `%s` in %s `%s`, perhaps add `static import %s;`", exp.ident.toChars(), ie.sds.kind(), ie.sds.toPrettyChars(), s.toPrettyChars());
Expand Down
2 changes: 1 addition & 1 deletion test/fail_compilation/dip22a.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ TEST_OUTPUT:
---
fail_compilation/dip22a.d(16): Error: no property `bar` for type `imports.dip22a.Klass`
fail_compilation/dip22a.d(17): Error: no property `bar` for type `imports.dip22a.Struct`
fail_compilation/dip22a.d(18): Error: undefined identifier `bar` in module `imports.dip22a`, did you mean function `bar`?
fail_compilation/dip22a.d(18): Error: undefined identifier `bar` in module `imports.dip22a`
fail_compilation/dip22a.d(19): Error: no property `bar` for type `void`
fail_compilation/dip22a.d(20): Error: no property `bar` for type `int`
---
Expand Down
4 changes: 2 additions & 2 deletions test/fail_compilation/fail10528.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
TEST_OUTPUT:
---
fail_compilation/fail10528.d(19): Error: undefined identifier `a`
fail_compilation/fail10528.d(20): Error: undefined identifier `a` in module `a10528`, did you mean variable `a`?
fail_compilation/fail10528.d(20): Error: undefined identifier `a` in module `a10528`
fail_compilation/fail10528.d(22): Error: undefined identifier `b`
fail_compilation/fail10528.d(23): Error: undefined identifier `b` in module `a10528`, did you mean enum member `b`?
fail_compilation/fail10528.d(23): Error: undefined identifier `b` in module `a10528`
fail_compilation/fail10528.d(25): Error: no property `c` for type `a10528.S`
fail_compilation/fail10528.d(26): Error: no property `c` for type `a10528.S`
fail_compilation/fail10528.d(28): Error: no property `d` for type `a10528.C`
Expand Down
13 changes: 13 additions & 0 deletions test/fail_compilation/fail20638.d
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/*
TEST_OUTPUT:
---
fail_compilation/fail20638.d(12): Error: undefined identifier `foo` in module `imports.fail20638b`
thewilsonator marked this conversation as resolved.
Show resolved Hide resolved
---
*/
module fail20638;

import imports.fail20638b;

void main() {
imports.fail20638b.foo;
}
3 changes: 3 additions & 0 deletions test/fail_compilation/imports/fail20638b.d
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module imports.fail20638b;

private void foo() { }