Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20831 - __traits(getAttributes) failes to compile when used… #11284

Merged
merged 1 commit into from Jun 17, 2020

Conversation

BorisCarvajal
Copy link
Member

… on a parameter with no name

I'm marking each Parameter that is actually a function parameter with STC.parameter, thus we can test if a Parameter instance is a function argument in a more robust way.
I've a couple of patchs for other issues using this approach.

An alternative fix is to generate identifiers for unnamed parameters in semantic 1, they are generated in semantic 3 which causes a few bugs now. I'll report them sometime.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @BorisCarvajal! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20831 normal __traits(getAttributes) failes to compile when used on a parameter with no name

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11284"

@dlang-bot dlang-bot merged commit 764b3d4 into dlang:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants