[dmd-cxx] fix Issue 21295: Add test for symbol lookup/resolve in compilation broken #11831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "dmd-cxx + dmd#11831" |
thewilsonator
approved these changes
Oct 7, 2020
ibuclaw
force-pushed
the
dmd-cxx-issue21295
branch
from
efbf805
to
fa1aaa4
Compare
MoonlightSentinel
approved these changes
Oct 11, 2020
sebhub
pushed a commit
to RTEMS/gnu-mirror-gcc
that referenced
this pull request
Oct 12, 2020
Fixes a symbol resolver bug where a private alias becomes public if used before its declaration. Reviewed-on: dlang/dmd#11831 gcc/d/ChangeLog: * dmd/MERGE: Merge upstream dmd 70aabfb51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strictly, this is related to good old issue 10378
In dmd mainline, this went from compilable -> fail_compilation due to an indirect bug fix.
In dmd-cxx, we're still in the deprecation transition phase for bug 10378, so we use
-deis used in the test instead.