Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dmd-cxx] fix Issue 21295: Add test for symbol lookup/resolve in compilation broken #11831

Merged
merged 2 commits into from
Oct 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/declaration.c
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,13 @@ void AliasDeclaration::semantic(Scope *sc)
void AliasDeclaration::aliasSemantic(Scope *sc)
{
//printf("AliasDeclaration::semantic() %s\n", toChars());

// as AliasDeclaration::semantic, in case we're called first.
// see https://issues.dlang.org/show_bug.cgi?id=21001
storage_class |= sc->stc & STCdeprecated;
protection = sc->protection;
userAttribDecl = sc->userAttribDecl;

// TypeTraits needs to know if it's located in an AliasDeclaration
sc->flags |= SCOPEalias;

Expand Down
12 changes: 12 additions & 0 deletions test/fail_compilation/fail21001.d
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/*
TEST_OUTPUT:
---
fail_compilation/fail21001.d(12): Error: undefined identifier `Alias`
---
*/

module fail21001;

import imports.fail21001b;

void main() { Alias var; }
5 changes: 5 additions & 0 deletions test/fail_compilation/imports/fail21001b.d
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module imports.fail21001b;

private struct S { Alias member; }

private alias Alias = int;
5 changes: 5 additions & 0 deletions test/fail_compilation/imports/issue21295ast_node.d
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module imports.issue21295ast_node;
import imports.issue21295visitor : Visitor;
class ASTNode {
void accept(Visitor);
}
4 changes: 4 additions & 0 deletions test/fail_compilation/imports/issue21295astcodegen.d
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module imports.issue21295astcodegen;
struct ASTCodegen {
import imports.issue21295dtemplate;
}
3 changes: 3 additions & 0 deletions test/fail_compilation/imports/issue21295dtemplate.d
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module imports.issue21295dtemplate;
import imports.issue21295ast_node;
class TemplateParameter : ASTNode { }
3 changes: 3 additions & 0 deletions test/fail_compilation/imports/issue21295visitor.d
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module imports.issue21295visitor;
import imports.issue21295astcodegen;
class Visitor { }
9 changes: 9 additions & 0 deletions test/fail_compilation/issue21295.d
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/*
REQUIRED_ARGS: -de
TEST_OUTPUT:
---
fail_compilation/issue21295.d(9): Deprecation: imports.issue21295ast_node.Visitor is not visible from module issue21295
---
*/
import imports.issue21295ast_node;
Visitor should_fail;