Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 21403 - dmd/backend/cgcs.d:375 assert failed #12304

Merged
merged 1 commit into from Mar 26, 2021

Conversation

WalterBright
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
21403 critical dmd/backend/cgcs.d:375 assert failed

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12304"

@UplinkCoder
Copy link
Member

This needs an explanation as to why el_una had to be changed for adressElem

@WalterBright
Copy link
Member Author

why el_una had to be changed for adressElem

I improved the documentation for addressElem()

test/runnable/test21403.d Outdated Show resolved Hide resolved
@WalterBright
Copy link
Member Author

The failures in the test don't make any sense.

@ibuclaw
Copy link
Member

ibuclaw commented Mar 25, 2021

The failures in the test don't make any sense.

You're right, they don't.

/tmp/dmd/generated/linux/release/64/dmd -m64 -fPIC -w -I../../src -I../../import -Isrc -defaultlib= -debuglib= -dip1000 -L-lpthread -L-lm -L/tmp/druntime/generated/linux/debug/64/libdruntime.a -g -debug -ofgenerated/linux/debug/64/assert_fail src/assert_fail.d
src/assert_fail.d(239): Error: template `core.internal.dassert._d_assert_fail` cannot deduce function from argument types `!()(string)`, candidates are:
../../src/core/internal/dassert.d(38):        `_d_assert_fail(A)(scope const string op, auto ref scope const A a)`
../../src/core/internal/dassert.d(59):        `_d_assert_fail(A...)`
src/assert_fail.d(240): Error: template `core.internal.dassert._d_assert_fail` cannot deduce function from argument types `!()(string)`, candidates are:
../../src/core/internal/dassert.d(38):        `_d_assert_fail(A)(scope const string op, auto ref scope const A a)`
../../src/core/internal/dassert.d(59):        `_d_assert_fail(A...)`
src/assert_fail.d(241): Error: template `core.internal.dassert._d_assert_fail` cannot deduce function from argument types `!()(string)`, candidates are:
../../src/core/internal/dassert.d(38):        `_d_assert_fail(A)(scope const string op, auto ref scope const A a)`
../../src/core/internal/dassert.d(59):        `_d_assert_fail(A...)`
Testing cycle_ignore

@ibuclaw
Copy link
Member

ibuclaw commented Mar 25, 2021

@WalterBright the last merged PR in druntime is causing the failure (dlang/druntime#3411), however this error goes away if you rebase on top of #12306.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants