Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 21752 - Template constraint breaks nested eponymeous template #12306

Merged

Conversation

MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented Mar 24, 2021

The callsc can be identical for deeply nested eponymeous templates or
while doing overload resolution, so ignore the failure if it's the first
checked scope.

CC @rainers because this modifies the check from #10239

The `callsc` can be identical for deeply nested eponymeous templates or
while doing overload resolution, so ignore the failure if it's the first
checked scope.
@MoonlightSentinel MoonlightSentinel marked this pull request as ready for review March 24, 2021 23:17
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21752 regression Template constraint breaks nested eponymeous template

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12306"

@dlang-bot dlang-bot merged commit 3a82ecf into dlang:master Mar 25, 2021
@MoonlightSentinel MoonlightSentinel deleted the nested-template-constraint branch March 25, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants