Merge stable into master #12408
Merged
Merge stable into master #12408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code may never throw exceptions in betterC mode, so it cannot abort the ctor with an uncaught exception.
…y/dtor call (dlang#12265) * Issue 21693 - Lower scoped destruction of extern(C++) class to destroy Ensures proper RAII behaviour for stack allocated instances but doesn't affect the behaviour for heap allocated instances. The previous rewrite used `delete` which relies on `TypeInfo` and crashed at runtime. Using `object.destroy` circumvents this issue (and is also beneficial due to the deprecation of `delete`). `destroy` can be used instead of `delete` because the instances live on the heap and hence don't need to be deallocated.
Co-authored-by: Johan Forsberg <johan.forsberg@akerstroms.se>
dlang#12302) * Fix issue 19192 - [wrong-code] [crashes] Covariant method interface <- abstract class <- class hierarchies While analyzing covariant methods, dmd semantic analyzer searched for immediate interfaces of the class that may have a vtbl entry matching the method. This failed for possible scenarios where the covariant method may be declared in an interface inheritance of an abstract base class. The fix adds a for loop that iterates over the base classes to find the relevant interface with matching vtbl entry.
…ecision These tests have regressed on Linux/AArch64 since dlang#12164.
Skip temporaries for `void` expressions and defer error messages to further semantic analysis.
The previous .cpp code was GNU-specific and required something like `-std=gnu++11` to compile with clang. Switch to C++11 and initializer lists instead.
…sses Iterate the inheritance chain for `extern(D)` classes to emulate the manual chaining implemented in `rt_finalise`.
...in class methods. The checks for such slices relied on `va` while actually just caring about the current type. This was broken by [1] which clears `va` for class members to detect escapes of delegates. This also applied to the checks for struct temporaries/literals. [1] dlang#8008
Because the `union` is initialised when one of its members has been constructed.
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#12408" |
thewilsonator
approved these changes
Apr 9, 2021
MoonlightSentinel
force-pushed
the
merge_stable
branch
from
1ed089a
to
90ca721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to resolve some merge conflicts up front and sync the changes e.g. to
escape.d.