fix Issue 22006 - static foreach and foreach over tuple doesn't work on 16-bit #12662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#12662" |
RazvanN7
approved these changes
Jun 9, 2021
ibuclaw
added a commit
to ibuclaw/dmd
that referenced
this pull request
Jun 10, 2021
…sn't work on 16-bit (dlang#12662)
ibuclaw
added a commit
to ibuclaw/dmd
that referenced
this pull request
Jun 11, 2021
…sn't work on 16-bit (dlang#12662)
UplinkCoder
pushed a commit
to UplinkCoder/dmd
that referenced
this pull request
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than restricting the
static foreachindex to a reduced set of types that excludes targets with a 16-bit size_t from working properly. Do the similar checks as regularforeachand error for all non-integral types, and types that cannot represent the full range of index values.