Bitfields posix #13027
Merged
Bitfields posix #13027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13027" |
WalterBright
force-pushed
the
bitfieldsPosix
branch
from
6ac4b22
to
d4f06c2
Compare
WalterBright
force-pushed
the
bitfieldsPosix
branch
from
d4f06c2
to
cc6b806
Compare
ibuclaw
requested changes
Aug 27, 2021
WalterBright
force-pushed
the
bitfieldsPosix
branch
from
cc6b806
to
2d87dc9
Compare
|
Looks like the test runner's predilection for only looking at stderr output is making a hash of this for me, as stderr is different on every platform. |
|
Anyone have a clever suggestion? |
WalterBright
force-pushed
the
bitfieldsPosix
branch
3 times, most recently
from
60c1a0d
to
0d3cf5b
Compare
ibuclaw
previously requested changes
Aug 27, 2021
ibuclaw
reviewed
Aug 27, 2021
WalterBright
force-pushed
the
bitfieldsPosix
branch
from
0d3cf5b
to
9ba9dfc
Compare
WalterBright
force-pushed
the
bitfieldsPosix
branch
from
9ba9dfc
to
6ec9f4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a lot of grief with this, due to the way Posix lays out bit fields not being documented.
The two test files are actually identical, except for the TEST_OUTPUT section. That section is generated by compiling the code with an actual C compiler, and inserting its output into that section.
I'll make a win32 and win64 version in a later PR.
@ibuclaw you have a good handle on how gcc works with this, so your review is especially appreciated. I'm not terribly confident everything is 100% right.