fix Issue 21969 - importC: Error: bit fields are not supported #13033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13033" |
thewilsonator
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was closed by #13031 and #13027, but after adding some more tests, found a problem with the implementation where
fieldState.offsetis not adjusted after the initial call tostartNewField, even though more bit-fields were added.This meant that in the second call to
startNewField(see test A9 or A10), thenextoffsetvalue was wrong.Values for MS Bitfields are pulled from godbolt, I've no idea if the MS path is correct in DMD: https://godbolt.org/z/6G4aWG8eG
I also have no idea what DM Bitfields do for the added tests, maybe @WalterBright can fill in those gaps.