Fix Issue 21794 - ICE: Assertion hit in dinterpret.d #13172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @BorisCarvajal! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#13172" |
|
The commit message is not particularly good. |
UplinkCoder
approved these changes
Oct 15, 2021
UplinkCoder
reviewed
Oct 15, 2021
src/dmd/dinterpret.d
Outdated
| if (tobt.isintegral()) | ||
| emplaceExp!(IntegerExp)(pue, e.loc, 0, e.to); | ||
| else if (tobt.isreal()) | ||
| emplaceExp!(RealExp)(pue, e.loc, 0, e.to); |
There was a problem hiding this comment.
it says that a longdouble_soft is expected.
BorisCarvajal
force-pushed
the
fix21794
branch
from
90c3fd3
to
cdfccb1
Compare
|
Commit message improved a little, it's really brief like every bug fix on the repo. |
RazvanN7
approved these changes
Oct 16, 2021
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
Jul 1, 2023
Backports ICE fix from upstream. When casting null to integer or real, instead of painting the type on the NullExp, we emplace an IntegerExp/RealExp with the value zero. Same as when casting from NullExp to bool. Reviewed-on: dlang/dmd#13172 PR d/110511 gcc/d/ChangeLog: * dmd/dinterpret.c (Interpreter::visit (CastExp *)): Handle casting null to int or float. gcc/testsuite/ChangeLog: * gdc.test/compilable/test21794.d: New test. (cherry picked from commit 066385c)
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
Jul 1, 2023
Backports ICE fix from upstream. When casting null to integer or real, instead of painting the type on the NullExp, we emplace an IntegerExp/RealExp with the value zero. Same as when casting from NullExp to bool. Reviewed-on: dlang/dmd#13172 PR d/110511 gcc/d/ChangeLog: * dmd/dinterpret.c (Interpreter::visit (CastExp *)): Handle casting null to int or float. gcc/testsuite/ChangeLog: * gdc.test/compilable/test21794.d: New test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When casting
nullto integer/real instead of painting the type on the NullExp, we emplace anIntegerExp/RealExpwith value zero like when casting fromNullExptobool.