backend: dwarfdbginf: Use LEB128 encoding for lines and columns #13246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using variable length form for lines and columns in debug info can decrease binary size from 1.04% for 16-bit and 3.06% for 32-bit according to my tests. These numbers were based on 100 000 functions with 4 variables. Increasing the line count makes less difference, increasing the variable count makes more difference. Overall it reduces the binary size on all tests. This adds the LEB128 encoding overhead however a SIMD implementation can be taken to consideration since the current implementation uses manual for loop. Signed-off-by: Luís Ferreira <contact@lsferreira.net>
|
Thanks for your pull request, @ljmf00! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13246" |
RazvanN7
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using variable length form for lines and columns in debug info can decrease
binary size from 1.04% for 16-bit and 3.06% for 32-bit according to my tests.
These numbers were based on 100 000 functions with 4 variables. Increasing the
line count makes less difference, increasing the variable count makes more
difference. Overall it reduces the binary size on all tests.
This adds the LEB128 encoding overhead however a SIMD implementation can be
taken to consideration since the current implementation uses manual for loop.
Signed-off-by: Luís Ferreira contact@lsferreira.net
This is related to what @WebFreak001 requested on #13204 .