Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "backend: dwarfdbginf: Use LEB128 encoding for lines and columns" #13499

Closed
wants to merge 1 commit into from

Conversation

MoonlightSentinel
Copy link
Contributor

Reverts #13246


Just checking whether this triggered the OMF pipelines to hang consistently (probably yet another OPTLINK bug)

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13499"

@ljmf00
Copy link
Member

ljmf00 commented Jan 7, 2022

AFAIK, this change doesn't affect OMF. Isn't CodeView debug info used instead?

@MoonlightSentinel
Copy link
Contributor Author

Indeed. Just checked the last few PR's that were merged before Azure reported the first timeout .

@MoonlightSentinel MoonlightSentinel deleted the revert-13246-use-leb128-form-dwarf branch February 8, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants