Fix Issue 22515 - Aggregate definition with qualifiers has inconsistencies between structs and classes #13312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @BorisCarvajal! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13312" |
BorisCarvajal
force-pushed
the
fix22515
branch
from
021308d
to
d2fd329
Compare
…ncies between structs and classes
BorisCarvajal
force-pushed
the
fix22515
branch
from
d2fd329
to
61cf164
Compare
RazvanN7
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broken behavior started in #783, then Walter fixed it in #6958 but unfortunately only for structs. Here I'm doing it for classes
and interfaces.There is a small change insrc/dmd/typinf.dbecause what is said in the comment is not happening for interfaces.Edit: Doing the change to
interfacesexposed some issues in their TypeInfo generation, so I'm fixing onlystructsfor now.