Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 13333 - Incorrect error ungagging during the resolution of forward references #3878

Merged
merged 5 commits into from Aug 20, 2014

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Aug 19, 2014

…forward references

Improve forward reference resolution in template instantiation with alias

- Check needGagging in TemplateInstance::semantic2()
- Set TemplateInstance::speculative if global.gag is set in semantic()
…regate members

It would cause unresolved forward reference because `TypeStruct::hasPointers()` requires the complete types of the fields.
By the improvement of recursive aliasing, we can simplify the concept to:
"A template instantiation during errors gagged is 'speculative instantiation'".
WalterBright added a commit that referenced this pull request Aug 20, 2014
Issue 13333 - Incorrect error ungagging during the resolution of forward references
@WalterBright WalterBright merged commit 78c3fd2 into dlang:master Aug 20, 2014
@9rnsr 9rnsr deleted the fix13333 branch August 21, 2014 00:02
9rnsr pushed a commit to 9rnsr/dmd that referenced this pull request Aug 26, 2014
Issue 13333 - Incorrect error ungagging during the resolution of forward references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants