Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 13333 - Incorrect error ungagging during the resolution of forward references #3878

Merged
merged 5 commits into from
Aug 20, 2014
Merged

Issue 13333 - Incorrect error ungagging during the resolution of forward references #3878

merged 5 commits into from
Aug 20, 2014

Commits on Aug 19, 2014

  1. fix Issue 13333 - Incorrect error ungagging during the resolution of … 

    …forward references

Improve forward reference resolution in template instantiation with alias

- Check needGagging in TemplateInstance::semantic2()
- Set TemplateInstance::speculative if global.gag is set in semantic()
    @9rnsr
    9rnsr committed Aug 19, 2014
    Configuration menu
    Copy the full SHA
    5b5945a View commit details
    Browse the repository at this point in the history

  2. Check unsafe variable declaring is unnecessary for function local agg… 

    …regate members

It would cause unresolved forward reference because `TypeStruct::hasPointers()` requires the complete types of the fields.
    @9rnsr
    9rnsr committed Aug 19, 2014
    Configuration menu
    Copy the full SHA
    7866eec View commit details
    Browse the repository at this point in the history

  3. Improve diagnostic in recursive template expansion

    @9rnsr
    9rnsr committed Aug 19, 2014
    Configuration menu
    Copy the full SHA
    d1446b0 View commit details
    Browse the repository at this point in the history

  4. [Refactoring] bool speculative

    @9rnsr
    9rnsr committed Aug 19, 2014
    Configuration menu
    Copy the full SHA
    3993011 View commit details
    Browse the repository at this point in the history

  5. [Refactoring] Remove global.speculativeGagging() 

    By the improvement of recursive aliasing, we can simplify the concept to:
"A template instantiation during errors gagged is 'speculative instantiation'".
    @9rnsr
    9rnsr committed Aug 19, 2014
    Configuration menu
    Copy the full SHA
    5038ab2 View commit details
    Browse the repository at this point in the history