Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 10925 - unittests qualified on the right hand side fail #4514

Closed
wants to merge 2 commits into from

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Mar 24, 2015

@9rnsr
Copy link
Contributor Author

9rnsr commented Mar 24, 2015

I'll open a documentation fix after the merge.

@Hackerpilot
Copy link
Member

This looks reasonable; we already allow this for asm blocks.

@WalterBright
Copy link
Member

I'm not too thrilled with this language change. First off, having the parens sometimes makes it confusing - when does one need them and when not? Second, adding more syntax without new capability and just as long just seems pointless. Third, adding new syntax that is redundant with existing syntax by just shuffling the order of keywords around may cause problems when significant new features are added later. Fourth, then we'll have to decide on what the "preferred" syntax is for style, and bikeshed about it, and write a style document, and add it to dfmt.

@WalterBright
Copy link
Member

I talked with Andrei about it, and we came to the conclusion that this change would cause problems for future possible enhancements to unittests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants