Issue 9383 - Wrong context for contracts if closure [dis]appears in override function

[9rnsr]

https://issues.dlang.org/show_bug.cgi?id=9383

[WalterBright]

s/funcitons/functions/

[9rnsr]

Thanks, fixed.

[9rnsr]

Thanks!

[schuetzm]

I think this broke something in my program. With this commit, I'm getting segfaults. Unfortunately this is a larger project, it will take some time to reduce, I guess.

Anyway, here is part of the backtrace:

#0  0x00007fffffffd800 in ?? ()
#1  0x0000000000aef840 in invariant._d_invariant(Object) ()
#2  0x0000000000997d67 in _long_mangled_name (this=0x7fffffffd630, __HID556=0x7fffffffd588) at orm/persistence.d:46
#3  0x0000000000990111 in _another_long_name (this=0x7ffff7ebff00) at orm/relations.d:22

The code around these lines is:

    // relations.d:
    @property accessor_(Class value)
    in {
        import vibe.data.bson : BsonObjectID;
        assert(value is null || value.id != BsonObjectID.init);
    } body {
        cache = value;
        if(value is null)
            mixin(key ~ " = BsonObjectID.init;");
        else
            mixin(key ~ " = value.id;");    // line 22
    }

    // persistence.d:
    static if(!hasField!(typeof(this), "_id")) {
        @Field
        BsonObjectID _id;
        @property id() const {    // line 46
            return _id;
        }
    }

@9rnsr Do you see anything suspicious? I can't be sure that I haven't done anything wrong, but I specifically checked (using writeln) that value is not null, so this can't be the reason.

[9rnsr]

@schuetzm This change actually introduced a git-head only regression 14779, and it's in progress to fix that in #4803.

[schuetzm]

Thank you! I can confirm that the SEGV disappears with your fix :-)

[WalterBright]

Introduced regression https://issues.dlang.org/show_bug.cgi?id=15984