[REG] Issue 14779 - incorrect addressing of arguments in require/in-contract

[9rnsr]

https://issues.dlang.org/show_bug.cgi?id=14779

In VarDeclaration::checkNestedReference(), although fdthis is '__require'
or '__ensure', and hat will get called directly and won't make outer functions
closure, the variable has to be appended to fdv->closureVars[] to make
fdv->hasNestedFrameRefs() returning true.

[MartinNowak]

Please target stable.
If you use the nice git-hub tool, it's as easy as git hub pull new -b stable.

[MartinNowak]

Ah, forget about my comment. The issue doesn't affect the stable branch.

[9rnsr]

Yes, recent wrong-code bug fixes around contracts are only in master branch.

[MartinNowak]

Sure this works well with https://github.com/D-Programming-Language/dmd/blob/4e5a31ec6be106ef6c30f7cb3f36de0c1447c8fb/src/func.c#L4377?

[9rnsr]

Sure this works well with https://github.com/D-Programming-Language/dmd/blob/4e5a31ec6be106ef6c30f7cb3f36de0c1447c8fb/src/func.c#L4377?

No, the property function is final, so isVirtualMethod() returns false.

[9rnsr]

@MartinNowak The line would be the correct location I should fix. When Walter had fixed issue 7335 in ff560ef, he added isVirtualMethod(), but it wrongly excluded final functions.

[9rnsr]

@MartinNowak All green.

[MartinNowak]

Auto-merge toggled on

[9rnsr]

Thanks!