omit frame for leaf functions on Linux, FreeBSD and OSX #5040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
force-pushed
the
noframe
branch
4 times, most recently
from
d1bce99
to
81ceda2
Compare
WalterBright
force-pushed
the
noframe
branch
from
81ceda2
to
9fe1641
Compare
|
Ready to rock. |
WalterBright
changed the title
|
This is an important optimization. Pls pull. |
|
ping @yebblies @MartinNowak |
|
Why isn't this being pulled? I want to do more optimizations. |
|
Looks like FreeBSD is randomly failing. Why can't we have a test suite that runs reliably? |
|
Because you're the only one that understands this code. |
|
All it is is not generating a BP stack frame if the function does not throw Exceptions or Errors. |
| /* Look for __va_argsave | ||
| */ | ||
| for (SYMIDX si = 0; si < globsym.top; si++) | ||
| { symbol *s = globsym.tab[si]; |
|
Auto-merge toggled on |
andralex
added a commit
that referenced
this pull request
Sep 9, 2015
omit frame for leaf functions on Linux, FreeBSD and OSX
andralex
added a commit
that referenced
this pull request
Sep 9, 2015
omit frame for leaf functions on Linux, FreeBSD and OSX
|
Question, |
|
yes |
mihails-strasuns-sociomantic
added a commit
to mihails-strasuns-sociomantic/dmd
that referenced
this pull request
Oct 28, 2015
* upstream/dmd-1.x: (37 commits) Add ddoc support for 'Template Params' section sync up with D2's backend fold in D2 changes fix build break Merge pull request dlang#5100 from WalterBright/movParams refactor: use LocalSection for alloca data Merge pull request dlang#5076 from WalterBright/AllocOff Merge pull request dlang#5064 from WalterBright/frame Merge pull request dlang#5070 from WalterBright/params Merge pull request dlang#5069 from WalterBright/go4 Merge pull request dlang#5067 from WalterBright/go3 Merge pull request dlang#5066 from WalterBright/go2 Merge pull request dlang#5065 from WalterBright/go Merge pull request dlang#5060 from WalterBright/floatalign Merge pull request dlang#5059 from WalterBright/cstop Merge pull request dlang#5040 from WalterBright/noframe Merge pull request dlang#5051 from WalterBright/movsx Merge pull request dlang#5024 from WalterBright/fakeeh Merge pull request dlang#4978 from WalterBright/rmVBTABLES Merge pull request dlang#4976 from WalterBright/backendgetRtlsym ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omitting the setup and teardown of the BP stack frame can speed up small functions.
Currently, this is done only for Win32. Unfortunately for other platforms, the exception unwinding system relies on there being a BP stack frame. So it is only possible to do this for 'leaf' functions which do not throw (not even throwing
Errors).Only doing this for Linux at the moment, will extend if successful.