Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG2.066] Issue 15422 - associative array of nested struct - crash on usage #5391

Merged
merged 2 commits into from
Feb 1, 2016

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Feb 1, 2016

Equivalent with #5308, excepting base branch.

If a struct is nested in a class, its `vthis` will be reference to the parent class, and struct default equality and hashing considers the parent class equality and hashing.
Otherwise, the `vthis` will be typed as void*, and pointer equality and hashing is merely used.
@dlang-bot
Copy link
Contributor

Fix Bugzilla Description
14442 Wrong this.outer reference in nested classes
15422 [REG2.066] associative array of nested struct - crash on usage

@ibuclaw
Copy link
Member

ibuclaw commented Feb 1, 2016

This looks fine.

@ibuclaw
Copy link
Member

ibuclaw commented Feb 1, 2016

Auto-merge toggled on

ibuclaw added a commit that referenced this pull request Feb 1, 2016
[REG2.066] Issue 15422 - associative array of nested struct - crash on usage
@ibuclaw ibuclaw merged commit 92b3fea into dlang:master Feb 1, 2016
@9rnsr 9rnsr deleted the fix15422 branch February 1, 2016 23:36
tramker added a commit to tramker/dmd that referenced this pull request Feb 6, 2016
[REG2.066] Issue 15422 - associative array of nested struct - crash on usage
Conflicts:
	src/aggregate.d
	test/runnable/nested.d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants