fix Issue 14162 - Erratic inference of @safe for lambdas #5881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1276,7 +1261,8 @@ extern (C++) class FuncDeclaration : Declaration | |||
| */ | |||
| TemplateInstance ti; | |||
| if (fbody && | |||
| (isFuncLiteralDeclaration() || (storage_class & STCinference) || (inferRetType && !isCtorDeclaration()) || isInstantiated() && !isVirtualMethod() && | |||
| (sc.func || isFuncLiteralDeclaration() || (storage_class & STCinference) || (inferRetType && !isCtorDeclaration()) || | |||
There was a problem hiding this comment.
Added sc.func here, because nested functions with bodies should have their attributes inferred unless overridden.
WalterBright
force-pushed
the
fix14162
branch
16 times, most recently
from
b324d31
to
b4e0260
Compare
|
Probably the most over-tested feature ever. |
WalterBright
force-pushed
the
fix14162
branch
2 times, most recently
from
0dcdd65
to
7e7d4c3
Compare
|
Blocked by dlang/phobos#4461 and dlang/phobos#4464 |
|
Auto-merge toggled on |
|
Blocked by dlang/phobos#4474 |
|
On Windows the tests fail for a different reason, btw: https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=2097110&isPull=true |
|
Blocked by dlang/phobos#4477 |
|
Blocked by dlang/phobos#4479 |
|
Blocked by dlang/phobos#4483 |
|
Blocked by dlang/phobos#4485 |
|
This introduced a regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inference of safety for lambdas should always occur if not explicitly set, because the source is always available.