fix Issue 17059 - incorrect circular reference with is(Klass : Interface)
#6412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…face)` - fixed by tweaking the fix for Issue 16980 (dlang#6383) - happened b/c TypeClass::implicitConv -> TypeClass::constConv checks for offset == 0, which triggered size finalization - instead handle unfinalized classes in isBaseOf (new OFFSET_FWDREF) and only explicity finalize size before optimizing casts - add a halt for any OFFSET_FWDREF leaking through to IR gen
ibuclaw
reviewed
Mar 20, 2017
| // https://issues.dlang.org/show_bug.cgi?id=16980 | ||
| cdfrom.size(e.loc); | ||
| assert(cdfrom.sizeok == SIZEOKdone); | ||
| assert(cdto.sizeok == SIZEOKdone || !cdto.isBaseOf(cdto, null)); |
There was a problem hiding this comment.
@MartinNowak - is this a typo? cdto.isBaseOf(cdto) - shouldn't the parameter be cdfrom?
Merged
|
This introduced a regression: https://issues.dlang.org/show_bug.cgi?id=17915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for offset == 0, which triggered size finalization
and only explicity finalize size before optimizing casts