Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 17059 - incorrect circular reference with is(Klass : Interface) #6412

Merged
merged 1 commit into from Jan 10, 2017
Merged

fix Issue 17059 - incorrect circular reference with is(Klass : Interface) #6412

merged 1 commit into from Jan 10, 2017

Commits on Jan 8, 2017

  1. fix Issue 17059 - incorrect circular reference with `is(Klass : Inter… 

    …face)`

- fixed by tweaking the fix for Issue 16980 (dlang#6383)
- happened b/c TypeClass::implicitConv -> TypeClass::constConv checks
  for offset == 0, which triggered size finalization
- instead handle unfinalized classes in isBaseOf (new OFFSET_FWDREF)
  and only explicity finalize size before optimizing casts
- add a halt for any OFFSET_FWDREF leaking through to IR gen
    @MartinNowak
    MartinNowak committed Jan 8, 2017
    Copy the full SHA
    c4ac1ab View commit details
    Browse the repository at this point in the history