use md5 to generate names for string comdats #6546
Conversation
WalterBright
force-pushed
the
md5-comdat
branch
2 times, most recently
from
3076b7b
to
5aad0fd
Compare
WalterBright
force-pushed
the
md5-comdat
branch
from
5aad0fd
to
648fda9
Compare
|
The win32 version exposed a bug in the Digital Mars implementation of |
|
Note that this change puts all string literals for Win32 and Win64 into readonly sections. Any code that tries to cast string literals to mutable strings and then write to them will now fail (which is what was wrong with String literals for Elf and Mach systems were already in readonly sections, so this would only affect non-portable Windows code. |
Where did you upload it to? Wouldn't it make sense to make the binary library available in a repository where everyone can (automatically) pick it up for a local build (including installers). |
|
You can pick it up here: |
|
@MartinNowak prepares the releases, so it's his decision as to the best way to package |
| @@ -5701,6 +5704,24 @@ Symbol *toStringSymbol(const(char)* str, size_t len, size_t sz, bool comdat = fa | |||
| OutBuffer buf; | |||
| buf.writestring("__"); | |||
| mangleToBuffer(se, &buf); // recycle how strings are mangled for templates | |||
|
|
|||
| if (buf.offset >= 32 + 2) | |||
| { // Replace long string with hash of that string | |||
There was a problem hiding this comment.
"no characters after an opening or closing brace"
There was a problem hiding this comment.
cc @wilzbach - we should tolerate this in the compiler for now, but not in druntime or phobos
There was a problem hiding this comment.
"no characters after an opening or closing brace"
Can't we automate that? It's an easy regex. And it shouldn't be too complex to only consider added lines of the patch.
We automatically pick-up and update to the latest libC, see https://github.com/dlang/installer/blob/5179af93d9f0fd84d714e8742492434bf16ed2f6/create_dmd_release/build_all.d#L459. Not a good "release" model, but changes to your libC are rare enough that I hardly care, still would be better with checksum and version. |
| ubyte u1 = u >> 4; | ||
| buf.writeByte((u1 < 10) ? u1 + '0' : u1 + 'A' - 10); | ||
| u1 = u & 0xF; | ||
| buf.writeByte((u1 < 10) ? u1 + '0' : u1 + 'A' - 10); |
|
sscanf doesn't occur in this patch, why does it need to be fixed? Win tester is currently failing due to dlang/druntime#1763 et.al. |
Because putting string literals in RO memory exposed the bug in sscanf. |
Because string literals can be arbitrarily long, and we don't need to ever reverse the comdat name to the string.
This PR also uses this technique for all Windows string literals now. Too bad Elf uses a completely different scheme.