Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] ELF: generate information for mutable pointers in DATA and TLS #6630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rainers
Copy link
Member

@rainers rainers commented Mar 15, 2017

This extends #6534 to ELF object files. It generates PC relative offsets into segments dat_ptr and tls_ptr.

The additional test cases also triggered failures for the Windows implementation, hopefully resolving why dlang/druntime#1763 failed the auto-tester.

@rainers
Copy link
Member Author

rainers commented Mar 25, 2017

Finally figured possible relocations. The additional test cases also triggered failures for the Windows implementation, hopefully resolving why dlang/druntime#1763 failed the auto-tester.

@ibuclaw
Copy link
Member

ibuclaw commented Jan 5, 2018

@rainers - Rebase? Where's the bugzilla issue? Is this really necessary?

@dlang-bot dlang-bot removed the stalled label Jan 6, 2018
@rainers
Copy link
Member Author

rainers commented Jan 6, 2018

Where's the bugzilla issue?

Related entries are https://issues.dlang.org/show_bug.cgi?id=14472 and https://issues.dlang.org/show_bug.cgi?id=4650, though addressing the problem from a slightly different angle.

Is this really necessary?

If we ever want to provide a precise GC, scanning the data segments precisely, too, can be very important (Visual D desperately needs it due to lots of stuff like GUIDs being interpreted as pointers). It can also speed up the scanning process as the pointer/non-pointer ratio in these segments can be pretty low.

This PR was my attempt at porting #6534 to linux. IIRC it almost worked but for shared libraries. Not being an expert for linux and ELF myself, I was hoping it could still be helpful to get it implemented for that platform.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@RazvanN7
Copy link
Contributor

@rainers where are we with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants