fix Issue 17388 - [scope] e[] should be treated like &e as far as sco… #7076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
|
WalterBright
force-pushed
the
fix17388
branch
4 times, most recently
from
4a3a1e5
to
1d7ff8b
Compare
MartinNowak
reviewed
Aug 10, 2017
| @@ -3267,6 +3267,9 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor | |||
| } | |||
| if (exp.e1.op == TOKslice || exp.e1.type.ty == Tarray || exp.e1.type.ty == Tsarray) | |||
| { | |||
| if (exp.e1.op == TOKslice) | |||
| (cast(SliceExp)exp.e1).arrayop = true; | |||
There was a problem hiding this comment.
I hope we can remove that special case once the library arrayOps story is merged. Still need to make it scope safe though.
|
Looks like you forgot PowAssignExp @WalterBright. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pe goes
&ewas working correctly, so the fix was to make slicing a static array follow the same logic.Had to make checkAddressVar() a global function so it can be called by both AddrExp and SliceExp.