more install.sh improvements #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @MartinNowak! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
MartinNowak
force-pushed
the
more_install_sh_improvements
branch
from
06d7b2f
to
4ddb58b
Compare
wilzbach
approved these changes
Sep 26, 2017
travis.sh
Outdated
| deactivate | ||
|
|
||
| fish <<-EOF | ||
| source ~/dlang/dmd-2.076.0/activate.fish |
There was a problem hiding this comment.
Shouldn't this be outside of the loop or $compiler?
There was a problem hiding this comment.
pardon me, leftover from local testing
wilzbach
reviewed
Sep 26, 2017
.travis.yml
Outdated
| include: | ||
| - os: linux | ||
| script: | ||
| - kcov $PWD/coverage ./travis.sh |
There was a problem hiding this comment.
Travis doesn't seem to like this.
MartinNowak
changed the title
MartinNowak
force-pushed
the
more_install_sh_improvements
branch
6 times, most recently
from
12da235
to
0222135
Compare
This was referenced Sep 26, 2017
MartinNowak
force-pushed
the
more_install_sh_improvements
branch
from
0222135
to
53ed3d1
Compare
|
Left out the fish shell test for now, the version on trusty (fish 2.0.0) cannot erase the fish_prompt function before restoring it. |
MartinNowak
force-pushed
the
more_install_sh_improvements
branch
2 times, most recently
from
bebdb0a
to
c6ca5c8
Compare
- test on osx as well
- need to reset script after in-place update or we're testing the live version
- unfortunately bash's local variables also hide globals in all nested function calls (which is surprising and a easily missed) - this script already uses global `path` and `local path`, and that issue was found when trying to move the `verify()` into `download()` - rename path -> ROOT, and the other globals to upcase names
- move verification from download_and_unpack to download
- also test $DC and $DMD env vars
- not supported for OSX on Travis-CI
MartinNowak
force-pushed
the
more_install_sh_improvements
branch
from
c6ca5c8
to
43fcfd1
Compare
- ldc-developers/ldc#2351 - fixed by using sed to read full stream
MartinNowak
force-pushed
the
more_install_sh_improvements
branch
from
29ba0a0
to
a4180cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.